Skip to content

feature: build binary for OS and arch by default#1487

Merged
TerryHowe merged 6 commits into
oras-project:mainfrom
TerryHowe:default-build-os-arch
Sep 12, 2024
Merged

feature: build binary for OS and arch by default#1487
TerryHowe merged 6 commits into
oras-project:mainfrom
TerryHowe:default-build-os-arch

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Build the binary by default for the current OS and arch.

@codecov

codecov Bot commented Aug 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.78%. Comparing base (a3b0601) to head (95da587).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1487   +/-   ##
=======================================
  Coverage   85.78%   85.78%           
=======================================
  Files         116      116           
  Lines        4073     4073           
=======================================
  Hits         3494     3494           
  Misses        347      347           
  Partials      232      232           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread Makefile Outdated
Comment thread Makefile
Comment thread Makefile Outdated
Comment thread Makefile
TerryHowe and others added 5 commits September 9, 2024 09:34
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the default-build-os-arch branch from 3ee6261 to 15d5364 Compare September 9, 2024 15:34

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Validated on Ubuntu and MAC

@TerryHowe TerryHowe merged commit 2808ea1 into oras-project:main Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants