fix: copy prompt skipped was missing#1484
Merged
Merged
Conversation
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
=======================================
Coverage 85.54% 85.54%
=======================================
Files 113 113
Lines 3936 3936
=======================================
Hits 3367 3367
Misses 342 342
Partials 227 227 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah
approved these changes
Aug 20, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
Nice catch, added unit test for that.
qweeah
reviewed
Aug 20, 2024
Member
|
The CodeCov scan seems failed in the CI. Should we fix it before merging this PR? |
Member
Author
|
Coverage on this file is 90% from my reading, but it just happens that renaming |
Member
Author
|
I'm going to ignore the bogus coverage report. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This is a bit confusing, but previously, OnCopySkipped prompted with "Exists" and PostCopy prompted with "Skipped". I think this was changed accidentally.
https://github.com/oras-project/oras/blob/release-1.2/cmd/oras/root/cp.go#L180:L189