refactor: create an interface for status console#1481
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1481 +/- ##
==========================================
- Coverage 86.10% 86.05% -0.06%
==========================================
Files 118 118
Lines 4224 4223 -1
==========================================
- Hits 3637 3634 -3
- Misses 350 351 +1
- Partials 237 238 +1 ☔ View full report in Codecov by Sentry. |
4af9db7 to
76ba908
Compare
sabre1041
approved these changes
Sep 28, 2024
qweeah
requested changes
Sep 29, 2024
qweeah
approved these changes
Sep 29, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
Thanks Terry for contributing. LGTM with minor sugggestions.
qweeah
approved these changes
Sep 29, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestions.
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
31dafc0 to
39fbfdb
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
39fbfdb to
83474e7
Compare
1 task
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Create a interface for console so that alternate implementations can exist. In doing this, I found the
Size()method was not properly implemented, so I created aGetHeightWidth()method.Partial: #1461