Skip to content

refactor: increase test coverage for mac for tty tests#1460

Merged
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:tty-console-test
Aug 2, 2024
Merged

refactor: increase test coverage for mac for tty tests#1460
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:tty-console-test

Conversation

@TerryHowe

@TerryHowe TerryHowe commented Jul 28, 2024

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Split the tty tests so coverage is better on mac.

I created an issue to mock the console

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Jul 28, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (c420cb1) to head (e324222).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1460   +/-   ##
=======================================
  Coverage   85.53%   85.53%           
=======================================
  Files         109      109           
  Lines        3851     3851           
=======================================
  Hits         3294     3294           
  Misses        333      333           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 5d4a835 into oras-project:main Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants