refactor: Move testutils to general location#1459
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1459 +/- ##
==========================================
- Coverage 85.54% 83.23% -2.31%
==========================================
Files 109 109
Lines 3853 3853
==========================================
- Hits 3296 3207 -89
- Misses 333 425 +92
+ Partials 224 221 -3 ☔ View full report in Codecov by Sentry. |
qweeah
requested changes
Aug 2, 2024
49f5281 to
9bab16f
Compare
qweeah
approved these changes
Aug 3, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestion.
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
9bab16f to
07aeeab
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The successor PR is big and still lacks coverage without more changes. This PR is for a small part of that change, just moving the console testutils to internal/testutils so we can have one testutils that is ignored by coverage.