Skip to content

refactor: replace error-ignored cobra output functions#1454

Merged
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:warning
Jul 23, 2024
Merged

refactor: replace error-ignored cobra output functions#1454
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:warning

Conversation

@qweeah

@qweeah qweeah commented Jul 23, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Fixes #1446

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov

codecov Bot commented Jul 23, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.53%. Comparing base (5067a9a) to head (c49884a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1454      +/-   ##
==========================================
+ Coverage   85.48%   85.53%   +0.05%     
==========================================
  Files         109      109              
  Lines        3851     3851              
==========================================
+ Hits         3292     3294       +2     
+ Misses        335      333       -2     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah merged commit 92bf5e3 into oras-project:main Jul 23, 2024
@TerryHowe

Copy link
Copy Markdown
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

avoid using error-ignored functions to print warning

3 participants