Skip to content

chore: Bring back the print error#1451

Merged
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:print-error-back
Jul 23, 2024
Merged

chore: Bring back the print error#1451
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:print-error-back

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

I'm not a big fan of the print error, but other things I am a lot more concerned with.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Jul 22, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (18f496c) to head (01d8e2c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1451      +/-   ##
==========================================
+ Coverage   85.42%   85.47%   +0.05%     
==========================================
  Files         109      109              
  Lines        3841     3842       +1     
==========================================
+ Hits         3281     3284       +3     
+ Misses        336      335       -1     
+ Partials      224      223       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 341ceb8 into oras-project:main Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants