refactor: Move channel write logic to manager#1445
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1445 +/- ##
==========================================
- Coverage 85.46% 85.41% -0.05%
==========================================
Files 108 108
Lines 3825 3827 +2
==========================================
Hits 3269 3269
- Misses 332 334 +2
Partials 224 224 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Jul 13, 2024
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
434c752 to
f16a833
Compare
qweeah
approved these changes
Jul 13, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM, will check if SendAndStop helps refactoring Prompt usage next week.
Member
Author
Sounds good. I was thinking there might be something there, but no clear vision of what right now. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move these progress bar channel operations out of handler and into the manager.