Skip to content

refactor: Create text copy handler#1441

Merged
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:text-copy-handler
Jul 23, 2024
Merged

refactor: Create text copy handler#1441
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:text-copy-handler

Conversation

@TerryHowe

@TerryHowe TerryHowe commented Jul 7, 2024

Copy link
Copy Markdown
Member

What this PR does / why we need it:

This is a baby step to creating copy handlers for the cp command

@codecov

codecov Bot commented Jul 7, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 92.59259% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.48%. Comparing base (7a88524) to head (361025d).

Files Patch % Lines
cmd/oras/internal/display/status/text.go 88.88% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1441      +/-   ##
==========================================
- Coverage   85.52%   85.48%   -0.05%     
==========================================
  Files         109      109              
  Lines        3842     3851       +9     
==========================================
+ Hits         3286     3292       +6     
- Misses        333      335       +2     
- Partials      223      224       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah
qweeah reviewed Jul 19, 2024
View reviewed changes
Comment thread cmd/oras/root/cp.go Outdated
qweeah
qweeah reviewed Jul 19, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/text.go
qweeah
qweeah reviewed Jul 19, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/text.go
qweeah
qweeah reviewed Jul 19, 2024
View reviewed changes
Comment thread cmd/oras/internal/display/status/text.go Outdated
qweeah
qweeah requested changes Jul 19, 2024
View reviewed changes

@qweeah qweeah left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to add TTY implementation of status.CopyHandler. Not necessarily needed in this PR.

@TerryHowe TerryHowe force-pushed the text-copy-handler branch from 99520bf to 11fd256 Compare July 19, 2024 22:42
@TerryHowe
refactor: Create text copy handler
faa4441 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe force-pushed the text-copy-handler branch from 11fd256 to faa4441 Compare July 19, 2024 22:48
@TerryHowe

TerryHowe commented Jul 22, 2024

Copy link
Copy Markdown
Member Author

Still need to add TTY implementation of status.CopyHandler. Not necessarily needed in this PR.

If this PR merges, it will be easier to create a tty handler and the successor PR is so bloated.

qweeah
qweeah approved these changes Jul 23, 2024
View reviewed changes

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 5067a9a into oras-project:main Jul 23, 2024
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qweeah qweeah qweeah approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TerryHowe @qweeah