Skip to content

chore: Remove last deprecated method#1438

Merged
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:remove-last-deprecated-method
Jul 3, 2024
Merged

chore: Remove last deprecated method#1438
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:remove-last-deprecated-method

Conversation

@TerryHowe

@TerryHowe TerryHowe commented Jul 1, 2024

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Remove the last deprecated method

@TerryHowe
chore: Remove last deprecated method
3e0e024 
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Jul 1, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.31%. Comparing base (374a1e3) to head (2555456).

Files Patch % Lines
cmd/oras/root/cp.go 66.66% 0 Missing and 1 partial ⚠️
cmd/oras/root/manifest/push.go 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1438      +/-   ##
==========================================
+ Coverage   85.28%   85.31%   +0.02%     
==========================================
  Files         107      106       -1     
  Lines        3800     3800              
==========================================
+ Hits         3241     3242       +1     
+ Misses        334      333       -1     
  Partials      225      225

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah
qweeah approved these changes Jul 2, 2024
View reviewed changes

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but I can see oras cp and oras manifest push still require a lot of refactoring. Thanks @TerryHowe

@qweeah
test(e2e): increase coverage
2555456 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@TerryHowe

TerryHowe commented Jul 2, 2024

Copy link
Copy Markdown
Member Author

LGTM but I can see oras cp and oras manifest push still require a lot of refactoring. Thanks @TerryHowe

I'll look at those next, thanks.

@qweeah qweeah merged commit f649643 into oras-project:main Jul 3, 2024
@qweeah

qweeah commented Jul 3, 2024

Copy link
Copy Markdown
Contributor

LGTM but I can see oras cp and oras manifest push still require a lot of refactoring. Thanks @TerryHowe

I'll look at those next, thanks.

Thanks, the main idea is to create dedicated display handler for cp and manifest push that implements a TaggedHandler like https://github.com/oras-project/oras/blob/f64964319489e88e4842d20b28428d1ffd065206/cmd/oras/internal/display/metadata/text/push.go#L41C1-L45C2

@qweeah qweeah mentioned this pull request Jul 3, 2024
Merged
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qweeah qweeah qweeah approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@shizhMSFT shizhMSFT Awaiting requested review from shizhMSFT shizhMSFT is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@TerryHowe @qweeah