Skip to content

refactor: Create tag handlers#1437

Merged
TerryHowe merged 4 commits into
oras-project:mainfrom
TerryHowe:tag-handler
Jul 1, 2024
Merged

refactor: Create tag handlers#1437
TerryHowe merged 4 commits into
oras-project:mainfrom
TerryHowe:tag-handler

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Create a tag handler for tagging

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Jun 28, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.23%. Comparing base (ecb7878) to head (3b6994f).

Current head 3b6994f differs from pull request most recent head 5589399

Please upload reports for the commit 5589399 to get more accurate results.

Files Patch % Lines
cmd/oras/root/tag.go 33.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage   85.22%   85.23%           
=======================================
  Files         106      107    +1     
  Lines        3798     3800    +2     
=======================================
+ Hits         3237     3239    +2     
  Misses        336      336           
  Partials      225      225           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah

qweeah commented Jun 29, 2024

Copy link
Copy Markdown
Contributor

Will take a look next week. Happy weekend!

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some comment changes.

Comment thread cmd/oras/internal/display/metadata/text/tag.go Outdated
Comment thread cmd/oras/internal/display/metadata/text/tag.go Outdated
TerryHowe and others added 3 commits July 1, 2024 08:17
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
Co-authored-by: Billy Zha <qweeah@gmail.com>
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@TerryHowe TerryHowe merged commit 374a1e3 into oras-project:main Jul 1, 2024
@TerryHowe TerryHowe deleted the tag-handler branch September 14, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants