Skip to content

build(ci): set codecov CLI version to avoid tokenless upload failure#1421

Merged
qweeah merged 3 commits into
oras-project:mainfrom
qweeah:fix-code-cov
Jun 21, 2024
Merged

build(ci): set codecov CLI version to avoid tokenless upload failure#1421
qweeah merged 3 commits into
oras-project:mainfrom
qweeah:fix-code-cov

Conversation

@qweeah

@qweeah qweeah commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

Try reset the CLI version since the last success run was based on Codecov CLI v0.6.0 https://github.com/oras-project/oras/actions/runs/9590619238/job/26446251379

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as draft June 21, 2024 01:29
qweeah added 2 commits June 21, 2024 01:37
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Jun 21, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.28%. Comparing base (55ca84a) to head (f042c51).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1421   +/-   ##
=======================================
  Coverage   85.28%   85.28%           
=======================================
  Files         106      106           
  Lines        3798     3798           
=======================================
  Hits         3239     3239           
  Misses        335      335           
  Partials      224      224           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah marked this pull request as ready for review June 21, 2024 03:39
@qweeah

qweeah commented Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

Related to codecov/codecov-action#1487

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT

Copy link
Copy Markdown
Contributor

Suggest creating an issue to track and revert this workaround.

@qweeah qweeah merged commit 37941a0 into oras-project:main Jun 21, 2024
@qweeah

qweeah commented Jun 21, 2024

Copy link
Copy Markdown
Contributor Author

Suggest creating an issue to track and revert this workaround.

Issue created #1423

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants