refactor: Pass printer to text handler#1420
Merged
TerryHowe merged 3 commits intoJun 21, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1420 +/- ##
==========================================
- Coverage 85.33% 85.32% -0.01%
==========================================
Files 106 106
Lines 3798 3810 +12
==========================================
+ Hits 3241 3251 +10
- Misses 333 334 +1
- Partials 224 225 +1 ☔ View full report in Codecov by Sentry. |
1f3be32 to
cf4f25f
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
cf4f25f to
0e22551
Compare
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Contributor
Making printer implement |
qweeah
approved these changes
Jun 21, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM, still need other reviewer approval on the printer's implementation of io.Writer
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Pass printer object to text handler.
I'm going to explore the possibility of passing the printer to the json and template handler, but trying to keep this small.