Skip to content

refactor: Move two output functions to the output package#1417

Merged
qweeah merged 1 commit into
oras-project:mainfrom
TerryHowe:move-to-output
Jun 20, 2024
Merged

refactor: Move two output functions to the output package#1417
qweeah merged 1 commit into
oras-project:mainfrom
TerryHowe:move-to-output

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Move the json and template output methods to the output package.

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Jun 19, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.28%. Comparing base (854ccc2) to head (85b2bab).

Files Patch % Lines
...d/oras/internal/display/metadata/table/discover.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1417      +/-   ##
==========================================
- Coverage   85.33%   85.28%   -0.06%     
==========================================
  Files         106      106              
  Lines        3798     3798              
==========================================
- Hits         3241     3239       -2     
- Misses        333      335       +2     
  Partials      224      224              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@qweeah qweeah merged commit 0bbd881 into oras-project:main Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants