refactor: Move descriptor logic to descriptor#1413
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1413 +/- ##
==========================================
+ Coverage 85.27% 85.28% +0.01%
==========================================
Files 107 107
Lines 3795 3798 +3
==========================================
+ Hits 3236 3239 +3
Misses 335 335
Partials 224 224 ☔ View full report in Codecov by Sentry. |
qweeah
requested changes
Jun 18, 2024
db1017c to
15e10f1
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
15e10f1 to
b3939e4
Compare
qweeah
approved these changes
Jun 18, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestion.
Co-authored-by: Billy Zha <qweeah@gmail.com> Signed-off-by: Terry Howe <terrylhowe@gmail.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Move the logic of descriptor title vs media type to the descriptor package.