Add e2e test go work sum file#1412
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1412 +/- ##
==========================================
- Coverage 85.14% 85.09% -0.06%
==========================================
Files 107 107
Lines 3790 3790
==========================================
- Hits 3227 3225 -2
- Misses 336 338 +2
Partials 227 227 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
7889a73 to
e80fa63
Compare
|
I would vote to ignore it, since the module sum of E2E test workspace should be tracked by |
|
Is there precedence in how other projects do this. I'm ok ignoring it but if this has some odd side effect of keeping or bringing unknown packages might move towards checkin this in. |
I do see kubernetes checks in the work sum file. But the usage is different. k8s' workspace is created on the root module level but ORAS' workspace is created on e2e test module level. So if we check go work sum file in, we are doing it for ORAS E2E test module, not for ORAS CLI module. Besides from testing packages (Gomega and Ginkgo), ORAS E2E test module should rely on same version of packages used by ORAS CLI module. So go work sum file won't be needed for cross-module package version control, and thus no need to check it in. |
|
IMHO, the only advantage we don't ignore go work sum file is: we can clearly see a package version mismatch between CLI and E2E test module. |
What this PR does / why we need it:
Add this file or ignore it?