Skip to content

refactor: clean status prompts#1409

Merged
TerryHowe merged 5 commits into
oras-project:mainfrom
qweeah:clean-prompt
Jun 17, 2024
Merged

refactor: clean status prompts#1409
TerryHowe merged 5 commits into
oras-project:mainfrom
qweeah:clean-prompt

Conversation

@qweeah

@qweeah qweeah commented Jun 17, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
As a follow up to #1407, this PR aligns the prompts naming for status handlers.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov

codecov Bot commented Jun 17, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 85.14%. Comparing base (e0b7cdd) to head (4d172e6).

Files Patch % Lines
cmd/oras/internal/display/status/text.go 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1409      +/-   ##
==========================================
+ Coverage   84.96%   85.14%   +0.18%     
==========================================
  Files         107      107              
  Lines        3790     3790              
==========================================
+ Hits         3220     3227       +7     
+ Misses        341      336       -5     
+ Partials      229      227       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah added 4 commits June 17, 2024 05:28
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 2aa005c into oras-project:main Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants