Skip to content

chore: Remove deprecated Print method#1398

Merged
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:deprecated-print
Jun 7, 2024
Merged

chore: Remove deprecated Print method#1398
qweeah merged 2 commits into
oras-project:mainfrom
TerryHowe:deprecated-print

Conversation

@TerryHowe

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Remove deprecated Print method

Signed-off-by: Terry Howe <terrylhowe@gmail.com>
@codecov

codecov Bot commented Jun 1, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.01%. Comparing base (554c103) to head (ddc36db).

Files Patch % Lines
cmd/oras/root/cp.go 0.00% 0 Missing and 1 partial ⚠️
cmd/oras/root/manifest/push.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1398      +/-   ##
==========================================
- Coverage   85.07%   85.01%   -0.06%     
==========================================
  Files         107      107              
  Lines        3805     3804       -1     
==========================================
- Hits         3237     3234       -3     
- Misses        339      341       +2     
  Partials      229      229              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah

qweeah commented Jun 4, 2024

Copy link
Copy Markdown
Contributor

DCO failing which blocks the PR check dcoapp/app#211

@qweeah qweeah merged commit d4eb7a8 into oras-project:main Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants