doc(spec): formatted ORAS CLI output#1199
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1199 +/- ##
=======================================
Coverage 84.96% 84.96%
=======================================
Files 107 107
Lines 3739 3739
=======================================
Hits 3177 3177
Misses 334 334
Partials 228 228 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
qweeah
reviewed
Dec 4, 2023
TerryHowe
reviewed
Dec 5, 2023
TerryHowe
reviewed
Dec 5, 2023
qweeah
reviewed
Dec 6, 2023
qweeah
reviewed
Dec 6, 2023
qweeah
reviewed
Dec 6, 2023
qweeah
reviewed
Dec 6, 2023
qweeah
reviewed
Dec 6, 2023
sajayantony
reviewed
Dec 6, 2023
toddysm
suggested changes
Dec 7, 2023
qweeah
reviewed
May 8, 2024
qweeah
reviewed
May 8, 2024
qweeah
reviewed
May 8, 2024
qweeah
reviewed
May 8, 2024
qweeah
reviewed
May 8, 2024
4 tasks
shizhMSFT
reviewed
May 9, 2024
shizhMSFT
left a comment
Contributor
There was a problem hiding this comment.
@FeynmanZhou Could you also fix the DCO issue?
sajayantony
approved these changes
May 9, 2024
sajayantony
left a comment
Contributor
There was a problem hiding this comment.
Non-blocking approve. Recommend addressing remaining comments from @shizhMSFT
qweeah
reviewed
May 10, 2024
qweeah
reviewed
May 10, 2024
qweeah
reviewed
May 10, 2024
qweeah
reviewed
May 10, 2024
qweeah
reviewed
May 10, 2024
qweeah
reviewed
May 10, 2024
qweeah
reviewed
May 11, 2024
qweeah
approved these changes
May 11, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestions on phrasing.
shizhMSFT
reviewed
May 11, 2024
ede73fa to
b27ec4c
Compare
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
shizhMSFT
requested changes
May 11, 2024
Signed-off-by: Feynman Zhou <feynmanzhou@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
add spec: Formatted ORAS CLI output
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #638