Skip to content

fix: atomic bool for layer skipped during pulling#1168

Merged
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:fix-race
Nov 6, 2023
Merged

fix: atomic bool for layer skipped during pulling#1168
qweeah merged 1 commit into
oras-project:mainfrom
qweeah:fix-race

Conversation

@qweeah

@qweeah qweeah commented Nov 3, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR avoids potential race condition when concurrently pulling an image.

@codecov-commenter

codecov-commenter commented Nov 3, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1168 (4fd2453) into main (24ac0c5) will not change coverage.
The diff coverage is 75.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##             main    #1168   +/-   ##
=======================================
  Coverage   80.03%   80.03%           
=======================================
  Files          65       65           
  Lines        3551     3551           
=======================================
  Hits         2842     2842           
  Misses        494      494           
  Partials      215      215           
Files Coverage Δ
cmd/oras/root/pull.go 74.43% <75.00%> (ø)

@TerryHowe

Copy link
Copy Markdown
Member

conflicts

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qweeah Please resolve conflicts

Comment thread cmd/oras/root/pull.go Outdated
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah

qweeah commented Nov 6, 2023

Copy link
Copy Markdown
Contributor Author

@TerryHowe @shizhMSFT Thanks for reviewing. Conflict & comments resolved.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit c7c7c3d into oras-project:main Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants