fix: should not print copy hint for manifest in verbose mode#1165
Merged
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1165 +/- ##
==========================================
- Coverage 79.94% 79.93% -0.01%
==========================================
Files 65 65
Lines 3520 3519 -1
==========================================
- Hits 2814 2813 -1
Misses 492 492
Partials 214 214
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR avoids wrong hinting on unnamed manifest/index in verbose mode.
Suppose we have below manifest stored in registry
Before the change, the verbose output will always hint user to use
oras copyto copy unnamed layer. But actually only the manifest is unnamedAfter the change, the verbose output will not do that