Skip to content

fix: resolve duplicated debug log for oras cp#1139

Merged
qweeah merged 2 commits into
oras-project:mainfrom
qweeah:fix-request-number
Oct 13, 2023
Merged

fix: resolve duplicated debug log for oras cp#1139
qweeah merged 2 commits into
oras-project:mainfrom
qweeah:fix-request-number

Conversation

@qweeah

@qweeah qweeah commented Oct 9, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR fixes a bug that causes duplicated numbering for debug logs

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1096

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@codecov-commenter

codecov-commenter commented Oct 9, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1139 (9ab60bb) into main (f1ef429) will decrease coverage by 0.06%.
The diff coverage is 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##             main    #1139      +/-   ##
==========================================
- Coverage   80.79%   80.73%   -0.06%     
==========================================
  Files          64       64              
  Lines        3374     3374              
==========================================
- Hits         2726     2724       -2     
- Misses        447      449       +2     
  Partials      201      201              
Files Coverage Δ
internal/trace/transport.go 82.35% <100.00%> (ø)

... and 1 file with indirect coverage changes

Comment thread test/e2e/suite/command/cp.go Outdated
Comment thread internal/trace/transport.go Outdated
Comment thread internal/trace/transport.go
Comment thread internal/trace/transport.go

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah force-pushed the fix-request-number branch from 43f6afb to 9ab60bb Compare October 13, 2023 08:43
@qweeah qweeah merged commit 6901c47 into oras-project:main Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: Unexpected request number in --debug log

7 participants