Skip to content

feat: support progress output for attach, push and copy commands#1138

Merged
qweeah merged 127 commits into
oras-project:mainfrom
qweeah:progress-bar-push-attach
Oct 23, 2023
Merged

feat: support progress output for attach, push and copy commands#1138
qweeah merged 127 commits into
oras-project:mainfrom
qweeah:progress-bar-push-attach

Conversation

@qweeah

@qweeah qweeah commented Oct 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR support progress bar for cp, attach and push commands.

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

qweeah added 30 commits September 12, 2023 07:06
@qweeah
feat: support progressed output in blob push and blob get
b088f2b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add error when --debug is used with terminal output
e773471 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
bug fix
6044594 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge branch 'main' into progress-bar-reader
b5d89dd
@qweeah
add test for console
6324b93 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix lint & pass tty to manager
f1077bd 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge branch 'main' into progress-bar-reader
4c362f8
@qweeah
rename flag to disable tty
941188f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add test for blob push
c72ebe5 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix render racing
5fc75a8 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix race
a2d3f8c 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add test for blob fetch
4a065fe 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
00ca2fc 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
c85e809 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
997a63e 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix lint
144e907 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor spinner mark
1b1f23c 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor: improve manager and status
008a61d 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
add error for manager functions
95ad473 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove unnecessary lock
ed84a69 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
update reader naming
47ef494 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove reader.once
7e249ed 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'origin_src/main' into progress-bar-reader
ca19602
@qweeah
ignore returned error of manager
a6476d4 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
8c7458b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
1584fd2 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'origin_src/main' into progress-bar-reader
8fef80b
@qweeah
code clean
b44e2e8 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
code clean
ea6476f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
feat: support progress bar for oras cp
b06383c 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review October 13, 2023 10:00
shizhMSFT
shizhMSFT reviewed Oct 16, 2023
View reviewed changes
Comment thread cmd/oras/internal/display/print.go
Comment thread cmd/oras/internal/display/track/target.go Outdated
Comment thread cmd/oras/internal/display/track/target.go Outdated
Comment thread cmd/oras/root/attach.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Comment thread cmd/oras/internal/display/track/target.go Outdated
qweeah added 9 commits October 17, 2023 02:01
@qweeah
resolve comment
781874f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
change target to graph target
0dd031a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
d2c8f16 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove printStatus output target.Prompt
0de9997 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
fix attach
e0f810a 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
refactor target
060940b 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
692fd31 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
doc clean
8a52cc9 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
Merge remote-tracking branch 'origin_src/main' into progress-bar-push…
1ccb8d1 
…-attach
shizhMSFT
shizhMSFT reviewed Oct 18, 2023
View reviewed changes
Comment thread cmd/oras/internal/display/print.go Outdated
Comment thread cmd/oras/internal/display/track/target.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Comment thread cmd/oras/root/cp.go Outdated
Comment thread cmd/oras/root/cp.go Outdated
qweeah added 4 commits October 19, 2023 03:16
@qweeah
resolve comment
826872f 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment for push
26cb0b7 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
resolve comment
d648b94 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove unnecessary code
f6ab85d 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT reviewed Oct 20, 2023
View reviewed changes
Comment thread cmd/oras/root/push.go Outdated
Comment thread cmd/oras/root/cp.go Outdated
Comment thread cmd/oras/root/cp.go Outdated
qweeah added 3 commits October 23, 2023 02:58
@qweeah
resolve comments
4841c1c 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
remove unused code
f30a5d5 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah
merge declaration
0406738 
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Oct 23, 2023
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit ace4255 into oras-project:main Oct 23, 2023
@shizhMSFT shizhMSFT mentioned this pull request Nov 22, 2023
Closed
1 task
@qweeah qweeah mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qweeah @codecov-commenter @shizhMSFT