fix: remove root from virtual referrers#1130
Merged
Merged
Conversation
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## main #1130 +/- ##
==========================================
- Coverage 80.10% 80.06% -0.05%
==========================================
Files 57 57
Lines 2991 2994 +3
==========================================
+ Hits 2396 2397 +1
- Misses 410 412 +2
Partials 185 185
|
Contributor
|
Should we include a test for this case? |
qweeah
approved these changes
Sep 23, 2023
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM. BTW is this allowed by spec? Having a subject which is also a member of manifests sound wierd.
Contributor
I can add one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix a bug when
oras cp -ra loop index.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1129
Please check the following list: