build: release ppc64le/riscv64 and improve reproducibility #1118
Merged
Conversation
TerryHowe
reviewed
Sep 12, 2023
AkihiroSuda
reviewed
Sep 12, 2023
qweeah
approved these changes
Sep 13, 2023
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM. I have verified that Linux and Windows amd64 binaries built are working as expected.
shizhMSFT
approved these changes
Sep 22, 2023
shizhMSFT
left a comment
Contributor
There was a problem hiding this comment.
LGTM with nit questions.
Contributor
|
@katexochen Could you rebase the branch so that we can merge? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1118 +/- ##
==========================================
+ Coverage 80.06% 80.12% +0.06%
==========================================
Files 57 57
Lines 2994 2994
==========================================
+ Hits 2397 2399 +2
+ Misses 412 410 -2
Partials 185 185 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
- trim paths - set build ID to empty string - set binary timestamp to commit timestamp - strip binary (reduces size from 9.2MB to 8.5MB) Signed-off-by: Paul Meyer <49727155+katexochen@users.noreply.github.com>
Contributor
Author
|
@shizhMSFT I rebased again, could you approve the CI? |
|
Just sayin', this enabled Armbian building on riscv64. Armbian uses ghcr.io + ORAS for distributed builds. Thank you! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Release for more architectures, as oras is getting more popular 🎉 and some use cases require more exotic architectures.
Also improving the reproducibility of release artifacts by
Which issue(s) this PR fixes:
Fixes #1111
Please check the following list: