perf: optimize request count for manifest and blob deletion#1109
Merged
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
shizhMSFT
reviewed
Sep 11, 2023
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Wwwsylvia
reviewed
Sep 12, 2023
Wwwsylvia
approved these changes
Sep 12, 2023
Wwwsylvia
left a comment
Member
There was a problem hiding this comment.
LGTM, but I'm not a maintainer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR optimize the request count of
oras blob deleteandoras manifest deletewhen using against a remote registry.When deleting a manifest via tag from registry, the requests are optimized as below:
Before
request
#0: HEAD manifest tag- 401request
#1: GET token (scope: pull) - 200request
#2: HEAD manifest tag- 200request
#3: GET manifest digest- 200request
#4: DELETE manifest digest 401request
#5: GET token (scope: delete, pull) - 200request
#6: DELETE manifest digest - 202After
request
#0: HEAD manifest tag- 401request
#1: GET token (scope: pull, delete, push) - 200request
#2: HEAD manifest tag- 200request
#3: GET manifest digest- 200request
#4: DELETE manifest digest - 202Same for
oras blob delete.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1104