Skip to content

doc: update example for oras push#1102

Merged
qweeah merged 4 commits into
oras-project:mainfrom
qweeah:example
Sep 1, 2023
Merged

doc: update example for oras push#1102
qweeah merged 4 commits into
oras-project:mainfrom
qweeah:example

Conversation

@qweeah

@qweeah qweeah commented Sep 1, 2023

Copy link
Copy Markdown
Contributor

This PR updates example for oras push command.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM but it seems we miss an example of setting artifact type.

Comment thread cmd/oras/root/push.go
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread cmd/oras/root/push.go Outdated
@codecov-commenter

codecov-commenter commented Sep 1, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.31%. Comparing base (5e98cec) to head (4ee78eb).
⚠️ Report is 549 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1102      +/-   ##
==========================================
+ Coverage   80.28%   80.31%   +0.02%     
==========================================
  Files          57       57              
  Lines        2927     2931       +4     
==========================================
+ Hits         2350     2354       +4     
  Misses        398      398              
  Partials      179      179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah requested a review from shizhMSFT September 1, 2023 08:33

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit b8db4fb into oras-project:main Sep 1, 2023
@qweeah qweeah deleted the example branch September 1, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants