Skip to content

test(e2e): fix logging when e2e test fails#1090

Merged
qweeah merged 2 commits into
oras-project:mainfrom
qweeah:zot-fix
Aug 29, 2023
Merged

test(e2e): fix logging when e2e test fails#1090
qweeah merged 2 commits into
oras-project:mainfrom
qweeah:zot-fix

Conversation

@qweeah

@qweeah qweeah commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

This PR re-enables log snapshotting when e2e fails

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Aug 29, 2023

Copy link
Copy Markdown

Codecov Report

Merging #1090 (e3b124b) into main (9974dc4) will decrease coverage by 0.07%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
- Coverage   79.99%   79.92%   -0.07%     
==========================================
  Files          56       56              
  Lines        2914     2914              
==========================================
- Hits         2331     2329       -2     
- Misses        405      407       +2     
  Partials      178      178              

see 1 file with indirect coverage changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qweeah qweeah merged commit 1c010cb into oras-project:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants