Skip to content

bump: use new packing function in oras-go#1070

Merged
TerryHowe merged 3 commits into
oras-project:mainfrom
qweeah:new_pack
Aug 22, 2023
Merged

bump: use new packing function in oras-go#1070
TerryHowe merged 3 commits into
oras-project:mainfrom
qweeah:new_pack

Conversation

@qweeah

@qweeah qweeah commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
This PR uses PackManifest in push and attach.

qweeah added 2 commits August 22, 2023 02:20
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review August 22, 2023 08:51
Comment thread go.sum Outdated
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Aug 22, 2023

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 79.93%. Comparing base (30abae3) to head (028e6e5).
⚠️ Report is 497 commits behind head on main.

Files with missing lines Patch % Lines
cmd/oras/internal/option/spec.go 50.00% 1 Missing ⚠️
cmd/oras/root/push.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1070      +/-   ##
==========================================
- Coverage   80.01%   79.93%   -0.08%     
==========================================
  Files          56       56              
  Lines        2897     2896       -1     
==========================================
- Hits         2318     2315       -3     
- Misses        402      404       +2     
  Partials      177      177              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 742b044 into oras-project:main Aug 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants