Skip to content

feat: pack OCI image spec v1.1 manifests#1054

Merged
qweeah merged 27 commits into
oras-project:mainfrom
qweeah:image-spec/rc4
Aug 18, 2023
Merged

feat: pack OCI image spec v1.1 manifests#1054
qweeah merged 27 commits into
oras-project:mainfrom
qweeah:image-spec/rc4

Conversation

@qweeah

@qweeah qweeah commented Aug 8, 2023

Copy link
Copy Markdown
Contributor

Fixes #1043, fixes #1062

Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as draft August 8, 2023 03:33
qweeah added 7 commits August 8, 2023 03:38
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added 2 commits August 9, 2023 03:22
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@codecov-commenter

codecov-commenter commented Aug 9, 2023

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 63.33333% with 22 lines in your changes missing coverage. Please review.

Project coverage is 79.94%. Comparing base (0e2e0f3) to head (0c382f4).
Report is 296 commits behind head on main.

Files with missing lines Patch % Lines
internal/graph/graph.go 55.55% 12 Missing and 4 partials ⚠️
cmd/oras/internal/option/spec.go 57.14% 3 Missing ⚠️
cmd/oras/root/push.go 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1054      +/-   ##
==========================================
- Coverage   80.97%   79.94%   -1.04%     
==========================================
  Files          56       56              
  Lines        2891     2897       +6     
==========================================
- Hits         2341     2316      -25     
- Misses        375      404      +29     
- Partials      175      177       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

qweeah added 10 commits August 9, 2023 03:32
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
@qweeah qweeah marked this pull request as ready for review August 10, 2023 01:53
Comment thread cmd/oras/internal/option/spec.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Comment thread internal/graph/graph.go
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
qweeah added 2 commits August 10, 2023 16:07
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread internal/graph/graph.go Outdated
Comment thread cmd/oras/root/push.go Outdated
Comment thread cmd/oras/root/cp.go
Comment thread internal/graph/graph.go
qweeah added 2 commits August 14, 2023 00:40
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Comment thread internal/graph/graph.go
Signed-off-by: Billy Zha <jinzha1@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

Comment thread internal/graph/graph.go Outdated
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Enable artifact guidance for ORAS update experimental flag image-spec

4 participants