Skip to content

Bug: valid profiler calibration input gets rejected as invalid #175

Description

@azolotko

Describe the bug
During refactoring in 4a43812#diff-dd77b6a74da25abd7eb268c0c2d42089L190-R191 a bug was introduced: only a javaVersionString that equals to CommonConstants.JDK_CVM_STRING will be considered as a valid calibration input. Most likely, it should be the other way around.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Application/Profile Startup
  2. Choose desired settings and press the Profile button.
  3. A "Calibration data missing" dialog appears stating that "Profiling cannot be started on this JDK" despite the profiling data being present and absolutely valid.

Expected behavior
Profiling should work on supported JVMs.

VisualVM log
messages.log

Screenshots
Screenshot 2020-02-22 at 22 50 53
Screenshot 2020-02-22 at 22 51 22
Screenshot 2020-02-22 at 22 51 27

Desktop (please complete the following information):

  • OS: macOS 10.15.3 (19D76)
  • JDK version [11.0.6; OpenJDK 64-Bit Server VM (11.0.6+9-jvmci-20.0-b02, mixed mode, sharing)]
  • Version [2.0 (Build 200206); platform 20191008-unknown-revn]
  • target JDK version [1.8.0_222; OpenJDK 64-Bit Server VM (AdoptOpenJDK)(build 25.222-b10, mixed mode)]

Metadata

Metadata

Assignees

Labels

Type

No type

Fields

No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions