Skip to content

feat: validate buildspec dockerfile#1280

Merged
AbhinavPradeep merged 7 commits into
mainfrom
abhinav/validate-buildspec-dockerfile
Feb 18, 2026
Merged

feat: validate buildspec dockerfile#1280
AbhinavPradeep merged 7 commits into
mainfrom
abhinav/validate-buildspec-dockerfile

Conversation

@AbhinavPradeep

Copy link
Copy Markdown
Contributor

Summary

The generated dockerfile now has a small validation script that compares the wheel names and file trees. The validation script is set to be the entrypoint when the built dockerfile is run.

Description of changes

  1. Added field upstream_artifacts to BaseBuildSpecDict.
  2. Using this, we generate the validation script and set it to run when the dockerfile is run.

@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 13, 2026
@AbhinavPradeep AbhinavPradeep marked this pull request as ready for review February 3, 2026 05:07
@AbhinavPradeep AbhinavPradeep force-pushed the abhinav/validate-buildspec-dockerfile branch 3 times, most recently from f89ceea to bc81c2f Compare February 10, 2026 01:31
@behnazh-w behnazh-w changed the base branch from main to abhinav/improve-buildspec-generation February 13, 2026 03:48

@behnazh-w behnazh-w left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the documentation at docs/source/pages/cli_usage/command_gen_build_spec.rst and docs/source/pages/tutorials/rebuild_third_party_artifacts.rst to explain the validation and how to run it.

Comment thread src/macaron/build_spec_generator/common_spec/pypi_spec.py Outdated
Comment thread src/macaron/build_spec_generator/common_spec/pypi_spec.py Outdated
Comment thread src/macaron/slsa_analyzer/package_registry/pypi_registry.py Outdated
Comment thread src/macaron/build_spec_generator/dockerfile/pypi_dockerfile_output.py Outdated
Comment thread src/macaron/build_spec_generator/dockerfile/pypi_dockerfile_output.py Outdated
Comment thread src/macaron/build_spec_generator/dockerfile/pypi_dockerfile_output.py Outdated
Comment thread src/macaron/build_spec_generator/dockerfile/pypi_dockerfile_output.py Outdated
Comment thread src/macaron/build_spec_generator/dockerfile/pypi_dockerfile_output.py Outdated
Comment thread src/macaron/build_spec_generator/dockerfile/pypi_dockerfile_output.py Outdated
@AbhinavPradeep AbhinavPradeep force-pushed the abhinav/improve-buildspec-generation branch from 615ffaf to acaddd9 Compare February 16, 2026 03:06
@AbhinavPradeep AbhinavPradeep force-pushed the abhinav/validate-buildspec-dockerfile branch from bc81c2f to 19bd222 Compare February 17, 2026 00:27
@AbhinavPradeep AbhinavPradeep marked this pull request as draft February 17, 2026 00:31
@AbhinavPradeep AbhinavPradeep marked this pull request as ready for review February 17, 2026 00:31
@behnazh-w behnazh-w changed the base branch from abhinav/improve-buildspec-generation to main February 17, 2026 00:53
@AbhinavPradeep AbhinavPradeep marked this pull request as draft February 17, 2026 01:10
@AbhinavPradeep AbhinavPradeep marked this pull request as ready for review February 17, 2026 01:10
@AbhinavPradeep AbhinavPradeep force-pushed the abhinav/validate-buildspec-dockerfile branch from 19bd222 to 321d930 Compare February 18, 2026 00:05
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
…resolution

Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
@AbhinavPradeep AbhinavPradeep force-pushed the abhinav/validate-buildspec-dockerfile branch from 321d930 to 289d091 Compare February 18, 2026 05:05
@AbhinavPradeep AbhinavPradeep merged commit fe4a048 into main Feb 18, 2026
9 checks passed
@behnazh-w behnazh-w deleted the abhinav/validate-buildspec-dockerfile branch April 8, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants