fix: sanitize version specifier and handled generator name edge case for Python builds#1247
Merged
Merged
Conversation
Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
eec8d83 to
e1ac713
Compare
…ion and fixed small bug with version regex. Signed-off-by: Abhinav Pradeep <abhinav.pradeep@oracle.com>
behnazh-w
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed logic related to parsing the "Generator: ..." line of
.dist_infoDescription of changes
pypi_spec.py, specifically addedparse_generator_versionso correctly sanitize and standardize the generator's version and added logic to handle the edge case of thebdist_wheelbuild backend. It's name is not indicative of the backend to be installed: insteadwheelmust be installed.