Skip to content

Minor label changes in JDK Downloader UI#580

Merged
Achal1607 merged 1 commit into
oracle:mainfrom
sid-srini:jdk-downloader-changes
Apr 6, 2026
Merged

Minor label changes in JDK Downloader UI#580
Achal1607 merged 1 commit into
oracle:mainfrom
sid-srini:jdk-downloader-changes

Conversation

@sid-srini

Copy link
Copy Markdown
Member
  1. Top button label changed to include the latest JDK version
  2. Oracle JDK versions selector options have " (LTS)" suffixed for LTS versions.
  3. Disable versions selector when only one option is present.

@sid-srini sid-srini added this to the JVSC 26.0.0 milestone Apr 6, 2026
@sid-srini sid-srini requested a review from Achal1607 April 6, 2026 07:19
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Apr 6, 2026
Achal1607
Achal1607 previously approved these changes Apr 6, 2026

@Achal1607 Achal1607 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @sid-srini!

Comment thread vscode/src/constants.ts Outdated
1. Top button label changed to include the latest JDK version
2. Oracle JDK versions selector options have " (LTS)" suffixed for LTS
   versions.
3. Disable versions selector when only one option is present.
4. Moved JdkVersionInfo to webviews/types and jdkDownloaderConstants to
   webviews/constants

@Achal1607 Achal1607 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@Achal1607 Achal1607 merged commit 76c88c6 into oracle:main Apr 6, 2026
2 checks passed
@sid-srini sid-srini deleted the jdk-downloader-changes branch April 6, 2026 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants