Skip to content

Refactor run configuration handling with VSCode variables support and centralize override logic#575

Merged
Achal1607 merged 2 commits into
oracle:mainfrom
Achal1607:refactored-runconfig-merge
Mar 31, 2026
Merged

Refactor run configuration handling with VSCode variables support and centralize override logic#575
Achal1607 merged 2 commits into
oracle:mainfrom
Achal1607:refactored-runconfig-merge

Conversation

@Achal1607

Copy link
Copy Markdown
Member

This PR refactors how run configuration overrides are applied during debugging by extracting the logic into a reusable utility runConfigurationUtils.ts.
Also, now run configuration settings section can use VSCode variables, it would be resolved by VSCode itself while running the debugger lifecycle.

…ored the runconfig settings merge logic with launch.json for better testiblity
@Achal1607 Achal1607 requested a review from sid-srini March 27, 2026 07:11
@oracle-contributor-agreement oracle-contributor-agreement Bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Mar 27, 2026
@Achal1607 Achal1607 added this to the JVSC 26.0.0 milestone Mar 27, 2026
Comment thread vscode/src/debugger/debugger.ts Outdated
sid-srini
sid-srini previously approved these changes Mar 30, 2026

@sid-srini sid-srini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Achal1607 for fixing this.

Please do update the copyright year in the existing files that have been modified here. Thanks.

@Achal1607 Achal1607 merged commit 399fc45 into oracle:main Mar 31, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OCA Verified All contributors have signed the Oracle Contributor Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants