[JVSC-249] Fix code folding in VS Code due to line-only folding limitation#304
Merged
Achal1607 merged 1 commit intooracle:mainfrom Oct 28, 2024
Merged
Conversation
Achal1607
reviewed
Oct 28, 2024
Achal1607
previously approved these changes
Oct 28, 2024
Member
Achal1607
left a comment
There was a problem hiding this comment.
We can add tests afterwards no issue. LGTM Thanks!
…ation Added the backport of the Netbeans PR apache/netbeans#7750 patch which allows supporting LSP clients which have line-only folding support. - This is the case of VS Code as referenced in microsoft/vscode#50840. Closes oracle#249 Signed-off-by: Siddharth Srinivasan <siddharth.srinivasan@oracle.com>
68c7ae0 to
077a2a6
Compare
Member
Author
Thanks. I will try adding the integration test in the .ts testsuite for this in a separate PR. |
Achal1607
approved these changes
Oct 28, 2024
Member
Achal1607
left a comment
There was a problem hiding this comment.
Thanks for resolving merge conflicts. LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the backport of the Netbeans PR apache/netbeans#7750 patch which allows supporting LSP clients which have line-only folding support.
Closes #249