Skip to content

Add support for javax.cache:cache-api:1.1.1#176

Merged
dnestoro merged 1 commit into
oracle:masterfrom
linghengqian:cache-api
Jan 16, 2023
Merged

Add support for javax.cache:cache-api:1.1.1#176
dnestoro merged 1 commit into
oracle:masterfrom
linghengqian:cache-api

Conversation

@linghengqian

Copy link
Copy Markdown
Contributor

What does this PR do?

Checklist before merging

  • I have properly formatted metadata files (see CONTRIBUTING document)
  • I have added thorough tests. (see this)

Comment on lines +29 to +46
{
"condition": {
"typeReachable": "java.lang.Object"
},
"name": "java.lang.String"
},
{
"condition": {
"typeReachable": "java.lang.Object"
},
"name": "java.lang.Number"
},
{
"condition": {
"typeReachable": "java.lang.Object"
},
"name": "java.lang.Integer"
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I was a bit surprised when I manually added these 3 GraalVM reachability metadata entries from nativeTest 's Error Log. This looks like something GraalVM needs to do, but now requires me to add them manually.

@mhalbritter mhalbritter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@dnestoro dnestoro merged commit 7bc34b1 into oracle:master Jan 16, 2023
@linghengqian linghengqian deleted the cache-api branch January 16, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for javax.cache:cache-api:1.1.1

3 participants