Add support for org.opengauss:opengauss-jdbc:3.1.0-og#168
Merged
Conversation
linghengqian
commented
Jan 9, 2023
Comment on lines
+238
to
+241
| // org.opengauss:opengauss-jdbc:3.1.0-og does not support java.time.OffsetTime | ||
| statement.setObject(16, LocalTime.of(23, 59, 0, 0)); | ||
| statement.setObject(17, LocalDateTime.of(2020, 1, 2, 23, 59, 0)); | ||
| statement.setObject(18, OffsetDateTime.of(2020, 1, 2, 23, 59, 0, 0, ZoneOffset.ofHours(3))); |
Contributor
Author
There was a problem hiding this comment.
- @edisonxiang I don't mean to bother, but some countries can't log into Gitee to report issues of opengauss-jdbc. Is it intentional that opengauss-jdbc does not support JSR-310?
7 tasks
vjovanov
approved these changes
Jan 11, 2023
vjovanov
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks a lot for your contributions!
2 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
org.opengauss:opengauss-jdbc:3.1.0#166.Checklist before merging