Add support for com.github.luben:zstd-jni:1.5.2-5#121
Merged
Conversation
linghengqian
commented
Nov 21, 2022
luben
reviewed
Nov 21, 2022
luben
reviewed
Nov 21, 2022
7070378 to
ed19fcf
Compare
7 tasks
c44effd to
6e96feb
Compare
Contributor
|
LGTM! |
3af6c15 to
04375b0
Compare
2 tasks
gradinac
reviewed
Dec 29, 2022
| @Test | ||
| void testCompressFile() throws IOException { | ||
| File file = new File("src/test/resources/originTest.txt"); | ||
| File outFile = new File("src/test/resources/originTest.txt.zs"); |
Contributor
There was a problem hiding this comment.
It may be worth writing these files to a temporary directory so that they don't pollute the main repository
Contributor
Author
There was a problem hiding this comment.
- Do you mean let me replace it with
java.io.File.createTempFile, and replace the tailassertDoesNotThrow(outFile::delete);withassertDoesNotThrow(outFile::deleteOnExit);? Do I need to keep committing to this PR or?
Contributor
There was a problem hiding this comment.
Exactly. I would commit the change to this PR :)
gradinac
approved these changes
Dec 29, 2022
Member
|
Could we also remove the merge commit from the history? |
Contributor
Author
|
4999878 to
e138b4f
Compare
Contributor
Author
|
Member
|
Looks good now, only one commit. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
com.github.luben:zstd-jni:1.5.2-5#120 .Checklist before merging