Skip to content

Add support for GraphQL Java 19.2#102

Merged
dnestoro merged 1 commit into
oracle:masterfrom
bclozel:graphql-java
Nov 16, 2022
Merged

Add support for GraphQL Java 19.2#102
dnestoro merged 1 commit into
oracle:masterfrom
bclozel:graphql-java

Conversation

@bclozel

@bclozel bclozel commented Nov 3, 2022

Copy link
Copy Markdown
Collaborator

This PR adds reachability metadata for the GraphQL Java project.

Tests involve a simple query to trigger the base infrastructure.
Since GraphQL Java will perform reflection mostly on user provided types, tests also use a complete introspection query on a complex schema to trigger reflection on GraphQL Java types.

Other Frameworks like Micronaut ship more metadata, but I didn't manage to trigger more reflection so far.

Pinging @melix as it's related to micronaut-projects/micronaut-core#7805

@bclozel bclozel marked this pull request as draft November 3, 2022 21:05
@bclozel bclozel marked this pull request as ready for review November 14, 2022 14:39
@bclozel

bclozel commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator Author

@dnestoro I think this PR is ready to be considered for the next release.

@dnestoro

Copy link
Copy Markdown
Contributor

@dnestoro I think this PR is ready to be considered for the next release.

Sure It will be reviewed and merged in next few days together with other PRs for next release

@@ -0,0 +1,3 @@
type Query {
greeting: String
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add new line


input NewCharacter {
name: String
} No newline at end of file

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here

@dnestoro

Copy link
Copy Markdown
Contributor

I added new lines directly from git

@dnestoro

Copy link
Copy Markdown
Contributor

@bclozel please resolve conflicts

This commit adds reachability metadata for the GraphQL Java project.
Tests involve a simple query to trigger the base infrastructure.
Since GraphQL Java will perform reflection mostly on user provided
types, tests also use a complete introspection query on a complex
schema to trigger reflection on GraphQL Java types.
@bclozel

bclozel commented Nov 16, 2022

Copy link
Copy Markdown
Collaborator Author

@dnestoro I've just force-pushed my branch with the fixes and it's ready for merging.

@dnestoro dnestoro merged commit f200d19 into oracle:master Nov 16, 2022
@bclozel bclozel deleted the graphql-java branch November 16, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants