Adjust ObjectStreamClass Cache recomputations for ClassCache#4485
Merged
graalvmbot merged 1 commit intooracle:masterfrom May 9, 2022
Merged
Adjust ObjectStreamClass Cache recomputations for ClassCache#4485graalvmbot merged 1 commit intooracle:masterfrom
graalvmbot merged 1 commit intooracle:masterfrom
Conversation
Contributor
Author
|
See #4477 (comment), it also affects JDK 11. I need to adjust the conditionals to take that into account. |
5dbe776 to
8f5a31d
Compare
Contributor
Author
|
Updated the PR to check presence/absence of |
8f5a31d to
f4d91fa
Compare
* Create a new conditional option for the presence/absence of java.io.ClassCache. * Use a custom recompute to create a new instance of the anonymous inner class implementations of ClassCache.
f4d91fa to
3f0fb41
Compare
dougxc
approved these changes
Apr 18, 2022
Member
dougxc
left a comment
There was a problem hiding this comment.
The changes look good to me however @christianwimmer or someone else from the SVM team should also review them.
Collaborator
|
Hello @christianwimmer could someone from the SVM team please review this? It's a blocker for building Mandrel with OpenJDK 17.0.4 and 11.0.16 EA releases (see graalvm#371). |
|
@oubidar-Abderrahim please create the usual Oracle-internal issues and PRs so that we can merge this. |
Collaborator
|
Thank you @christianwimmer and @oubidar-Abderrahim ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4477