Skip to content

Fix test for FastAIV2PruningCallback#265

Merged
c-bata merged 2 commits intooptuna:mainfrom
not522:fix-fastai-test
Jan 19, 2026
Merged

Fix test for FastAIV2PruningCallback#265
c-bata merged 2 commits intooptuna:mainfrom
not522:fix-fastai-test

Conversation

@not522
Copy link
Copy Markdown
Member

@not522 not522 commented Jan 19, 2026

Motivation

fastcore v1.12.2 contains a SyntaxError that causes CI failures, so this PR adds a version constraint.
ref: AnswerDotAI/fastcore#751

Description of the changes

  • Add a version constraint.
  • Remove try_import to make import errors more understandable.

@not522 not522 added the CI Continuous integration. label Jan 19, 2026
@not522
Copy link
Copy Markdown
Member Author

not522 commented Jan 19, 2026

@c-bata Could you review this PR?

Copy link
Copy Markdown
Member

@c-bata c-bata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@c-bata c-bata added this to the v4.8.0 milestone Jan 19, 2026
@c-bata c-bata merged commit 9a8d0ec into optuna:main Jan 19, 2026
129 checks passed
@not522 not522 deleted the fix-fastai-test branch January 19, 2026 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants