Skip to content

Update sklearn.py to fix mypy checks#249

Merged
nabenabe0928 merged 1 commit intooptuna:mainfrom
c-bata:fix-ci-mypy-checks
Sep 16, 2025
Merged

Update sklearn.py to fix mypy checks#249
nabenabe0928 merged 1 commit intooptuna:mainfrom
c-bata:fix-ci-mypy-checks

Conversation

@c-bata
Copy link
Copy Markdown
Member

@c-bata c-bata commented Sep 16, 2025

Motivation

To resolve https://github.com/optuna/optuna-integration/actions/runs/17749106577/job/50440455078

optuna_integration/sklearn/sklearn.py:324: error: Argument 1 to "report" of "Trial" has incompatible type "floating[Any]"; expected "float"  [arg-type]
Found 1 error in 1 file (checked 2 source files)

Description of the changes

Update sklearn.py to fix mypy checks

@c-bata c-bata added the CI Continuous integration. label Sep 16, 2025
@c-bata
Copy link
Copy Markdown
Member Author

c-bata commented Sep 16, 2025

@nabenabe0928 Could you review this PR?

Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 added this to the v4.6.0 milestone Sep 16, 2025
@nabenabe0928 nabenabe0928 merged commit 68c503a into optuna:main Sep 16, 2025
31 checks passed
@c-bata c-bata deleted the fix-ci-mypy-checks branch September 16, 2025 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants