Conversation
c-bata
left a comment
There was a problem hiding this comment.
Thank you for your pull request. I left one suggestion.
| "tensorboard": ["TensorBoardCallback"], | ||
| "tensorflow": ["TensorFlowPruningHook"], | ||
| "tfkeras": ["TFKerasPruningCallback"], | ||
| "version": ["__version__"], |
There was a problem hiding this comment.
nit: optuna_integration.version modules has no dependencies, so can we simply add from optuna_integration import version and update __all__ variable to include it?
| "version": ["__version__"], |
There was a problem hiding this comment.
I don't know if my modification is what you wanted, but I applied some changes.
import optuna_integration
from optuna_integration import __version__
from optuna_integration import version
print(optuna_integration.__version__, version.__version__, __version__)There was a problem hiding this comment.
Thanks for the update! My original intention was that since optuna_integration.version has no dependencies, we don’t need to include it in _import_structure for lazy import. Instead, we can just import __version__ like below.
diff --git a/optuna_integration/__init__.py b/optuna_integration/__init__.py
index c9436ff..18cab7e 100644
--- a/optuna_integration/__init__.py
+++ b/optuna_integration/__init__.py
@@ -4,6 +4,7 @@ from types import ModuleType
from typing import Any
from typing import TYPE_CHECKING
+from optuna_integration import version
from optuna_integration.version import __version__
@@ -30,13 +31,13 @@ _import_structure = {
"tensorboard": ["TensorBoardCallback"],
"tensorflow": ["TensorFlowPruningHook"],
"tfkeras": ["TFKerasPruningCallback"],
- "version": ["__version__"],
"wandb": ["WeightsAndBiasesCallback"],
"xgboost": ["XGBoostPruningCallback"],
}
__all__ = [
+ "version",
"__version__",
"AllenNLPExecutor",
"AllenNLPPruningCallback",However, I've just noticed that above change does not work as expected:
$ python -c "import optuna_integration; print(optuna_integration.version.__version__)"
Traceback (most recent call last):
File "<string>", line 1, in <module>
File "/home/cbata/go/src/github.com/optuna/optuna-integration/optuna_integration/__init__.py", line 128, in __getattr__
raise AttributeError("module {} has no attribute {}".format(self.__name__, name))
AttributeError: module optuna_integration has no attribute version
Could you please revert back to the previous implementation? Sorry for the confusion 🙇 I will approve once it's reverted.
There was a problem hiding this comment.
@c-bata
Thank you for the clarification, I have reverted the code!
|
Let me remove the |
c-bata
left a comment
There was a problem hiding this comment.
I confirmed that the following code works as expected.
>>> import optuna_integration
>>> optuna_integration.__version__
'4.6.0.dev'
>>> optuna_integration.version.__version__
'4.6.0.dev'
Motivation
This PR adds
__version__to directly underoptuna_integration.Description of the changes
__version__fromoptuna_integration