Move optuna._lightgbm_tuner module#233
Conversation
|
This pull request has not seen any recent activity. |
|
@milkcoffeen The CI job failed due to type-hinting problems. Could you resolve them, please? |
|
Sorry for the delayed response. I've made the correction. |
toshihikoyanase
left a comment
There was a problem hiding this comment.
The change overall looks excellent to me, but I found some minor issues.
Could you check them?
|
|
||
| # API from lightgbm_tuner. | ||
| for api_name in _names_from_tuners: | ||
| print(tuner.__dict__.keys()) |
There was a problem hiding this comment.
A nit, but this line seems to be a debug print. Could you remove it?
| print(tuner.__dict__.keys()) |
tests/lightgbm/test_optimize.py
Outdated
| from optuna_integration._lightgbm_tuner.optimize import _OptunaObjectiveCV | ||
| from optuna_integration._lightgbm_tuner.optimize import LightGBMTuner | ||
| from optuna_integration._lightgbm_tuner.optimize import LightGBMTunerCV | ||
| import optuna_integration.lightgbm |
There was a problem hiding this comment.
In my environment, the test worked without this line.
Since we import the optuna_integration module, we might not need to import the public modules under it.
| import optuna_integration.lightgbm |
|
Thank you for your review. |
toshihikoyanase
left a comment
There was a problem hiding this comment.
Thank you for your update. The change looks great to me.
optuna._lightgbm_tuner module
|
I slightly modified the PR title. Let me merge this PR. |
Motivation
This pull request refactors the
optuna_integration.lightgbmmodule to reorganize thelightgbm_tunercode under a new submodule structure. The changes primarily involve moving and renaming files, updating import paths, and ensuring tests and functionality remain consistent with the new structure.Description of the changes
Moved the lightgbm_tuner folder under lightgbm
As part of this change, we've modified the import paths.