Merged
Conversation
toshihikoyanase
approved these changes
May 31, 2025
Member
toshihikoyanase
left a comment
There was a problem hiding this comment.
The change in this PR is based on https://github.com/optuna/optuna/blob/master/.pre-commit-config.yaml.
mypy is not included in this PR, but it seems reasonable since the dependencies differ module by module.
LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This pull request introduces a pre-commit framework to enforce coding standards and streamline code formatting. It includes updates to the
.pre-commit-config.yamlfile for configuring pre-commit hooks and updates to theCONTRIBUTING.mdfile to guide contributors on using the new setup.Description of the changes