Merged
Conversation
Contributor
|
@ParagEkbote Could you fix the CI? |
Contributor
Author
|
I have formatted the example in a similar manner as the pycma example, yet the doc build fails. Could you please let me know what corrections are required. cc: @nabenabe0928 |
| .. testcode:: | ||
|
|
||
| import optuna | ||
| from optuna.integration import ShapleyImportanceEvaluator |
Contributor
There was a problem hiding this comment.
Could you please call plot_param_importances somewhere below?
Contributor
Author
There was a problem hiding this comment.
Updated as discussed. I'm unable to understand why the doc build keeps failing. Could you please help?
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Contributor
Author
|
The CI run is passing :) Could you please review? cc: @nabenabe0928 |
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the changes
As discussed here, I have added the example for SHAP in the docstring.
I need some help to correct the docstring formatting.
Could you please review?
cc: @nabenabe0928