Skip to content

Add SHAP Example #227

Merged
nabenabe0928 merged 14 commits intooptuna:mainfrom
ParagEkbote:Add-SHAP
May 16, 2025
Merged

Add SHAP Example #227
nabenabe0928 merged 14 commits intooptuna:mainfrom
ParagEkbote:Add-SHAP

Conversation

@ParagEkbote
Copy link
Copy Markdown
Contributor

@ParagEkbote ParagEkbote commented Apr 28, 2025

Description of the changes

As discussed here, I have added the example for SHAP in the docstring.

I need some help to correct the docstring formatting.

Could you please review?

cc: @nabenabe0928

@nabenabe0928
Copy link
Copy Markdown
Contributor

@ParagEkbote Could you fix the CI?

@ParagEkbote
Copy link
Copy Markdown
Contributor Author

I have formatted the example in a similar manner as the pycma example, yet the doc build fails.

Could you please let me know what corrections are required.

cc: @nabenabe0928

.. testcode::

import optuna
from optuna.integration import ShapleyImportanceEvaluator
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please call plot_param_importances somewhere below?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated as discussed. I'm unable to understand why the doc build keeps failing. Could you please help?

Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
@ParagEkbote
Copy link
Copy Markdown
Contributor Author

The CI run is passing :) Could you please review?

cc: @nabenabe0928

@ParagEkbote ParagEkbote requested a review from nabenabe0928 May 16, 2025 07:05
Co-authored-by: Shuhei Watanabe <47781922+nabenabe0928@users.noreply.github.com>
Copy link
Copy Markdown
Contributor

@nabenabe0928 nabenabe0928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nabenabe0928 nabenabe0928 merged commit 0afb815 into optuna:main May 16, 2025
30 checks passed
@ParagEkbote ParagEkbote deleted the Add-SHAP branch May 16, 2025 10:26
@nabenabe0928 nabenabe0928 added the document Documentation related. label May 16, 2025
@nabenabe0928 nabenabe0928 added this to the v4.4.0 milestone May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Documentation related.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants