Skip to content

Fix a bug of lightgbm tuner for Python 3.8 users#214

Merged
HideakiImamura merged 1 commit intooptuna:mainfrom
c-bata:fix-lightgbm-python3.8
Mar 25, 2025
Merged

Fix a bug of lightgbm tuner for Python 3.8 users#214
HideakiImamura merged 1 commit intooptuna:mainfrom
c-bata:fix-lightgbm-python3.8

Conversation

@c-bata
Copy link
Copy Markdown
Member

@c-bata c-bata commented Mar 21, 2025

Motivation

Follow-up #212

After merging #212, CI workflows in optuna-integration and optuna-examples became being failed as shown below:

Description of the changes

Use typing.List instead of list for Python 3.8 users.

@c-bata c-bata added the CI Continuous integration. label Mar 21, 2025
@c-bata
Copy link
Copy Markdown
Member Author

c-bata commented Mar 21, 2025

Please note that CI workflow for lightgbm wasn't triggered since this PR updates _lightgbm_tuner package. I confirmed that this PR fixes the failures on my laptop.

@c-bata
Copy link
Copy Markdown
Member Author

c-bata commented Mar 21, 2025

@nabenabe0928 Could you review this PR?

Copy link
Copy Markdown
Member

@HideakiImamura HideakiImamura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@HideakiImamura HideakiImamura merged commit cdd8e94 into optuna:main Mar 25, 2025
26 checks passed
@c-bata c-bata deleted the fix-lightgbm-python3.8 branch March 25, 2025 04:16
@c-bata c-bata added this to the v4.3.0 milestone Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Continuous integration.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants