Convert storage into InMemoryStorage before copying to the local#213
Merged
HideakiImamura merged 2 commits intooptuna:mainfrom Mar 21, 2025
Merged
Conversation
Member
|
@HideakiImamura Could you review this PR? |
HideakiImamura
approved these changes
Mar 21, 2025
Member
HideakiImamura
left a comment
There was a problem hiding this comment.
Thanks for the PR. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #211
Description of the changes
When copying the storage from the cluster to local, the storage itself was serialized and transferred, but the SQLite DB file referenced by
RDBStoragewas not included. This caused issues like the one in issue #211.By converting the storage to
InMemoryStorageon the cluster side before copying, the process now works correctly.