Merged
Conversation
|
This pull request has not seen any recent activity. |
not522
reviewed
Dec 24, 2025
Member
not522
left a comment
There was a problem hiding this comment.
Sorry for my late response and thank you for your PR! It's almost LGTM.
I added small comments. Could you check them?
not522
reviewed
Dec 24, 2025
Co-authored-by: Naoto Mizuno <naotomizuno@preferred.jp>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The Spark example does not use Spark's parallelism but calculates one parameter at the time in Spark. The point of the ask-and-tell functionality is to calculate batches of parameters. This PR fixes (#341)
Description of the changes
In the script we now loop over batches and within each batch we calculate parameter candidates in parallel in Spark.